linux-kernel - linux-next: simple boot test failure (Was: linux-next: Tree for Oct 9)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241009232216.6f0a28e5@canb.auug.org.au>
Date: Wed, 9 Oct 2024 23:22:16 +1100
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Linux Next Mailing List <linux-next@...r.kernel.org>, Linux Kernel
 Mailing List <linux-kernel@...r.kernel.org>, Christian Brauner
 <brauner@...nel.org>
Subject: linux-next: simple boot test failure (Was: linux-next: Tree for Oct
 9)

Hi all,

On Wed, 9 Oct 2024 18:20:16 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> News: this release fails my very simple qemu boot test.  It looks normal
> up to user mode and I even get a login prompt, but when I log in I get
> dumped back to the login prompt - presumably the shell is failing to run.

Bisected to

218a562f273bec7731af4e713df72d2c8c8816e8 is the first bad commit
commit 218a562f273bec7731af4e713df72d2c8c8816e8
Author: Al Viro <viro@...iv.linux.org.uk>
Date:   Mon Oct 7 18:43:57 2024 +0100

    make __set_open_fd() set cloexec state as well
    
    ->close_on_exec[] state is maintained only for opened descriptors;
    as the result, anything that marks a descriptor opened has to
    set its cloexec state explicitly.
    
    As the result, all calls of __set_open_fd() are followed by
    __set_close_on_exec(); might as well fold it into __set_open_fd()
    so that cloexec state is defined as soon as the descriptor is
    marked opened.
    
    Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
    Link: https://lore.kernel.org/r/20241007174358.396114-10-viro@zeniv.linux.org.uk
    Signed-off-by: Christian Brauner <brauner@...nel.org>

And reverting that commit from today's linux-next fixes my problem.
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped