linux-kernel - Re: [PATCH v8 1/1] pwm: imx27: workaround of the pwm output bug when decrease the duty cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41cc47bd-f18f-463b-a0dc-843088ecf91e@denx.de>
Date: Wed, 9 Oct 2024 03:55:35 +0200
From: Marek Vasut <marex@...x.de>
To: Frank Li <Frank.Li@....com>, u.kleine-koenig@...libre.com
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, festevam@...il.com,
 francesco@...cini.it, imx@...ts.linux.dev, jun.li@....com,
 kernel@...gutronix.de, krzk+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-pwm@...r.kernel.org, p.zabel@...gutronix.de, pratikmanvar09@...il.com,
 robh@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org,
 xiaoning.wang@....com
Subject: Re: [PATCH v8 1/1] pwm: imx27: workaround of the pwm output bug when
 decrease the duty cycle

On 10/8/24 9:41 PM, Frank Li wrote:

[...]

> +	c = clkrate * 1500;
> +	do_div(c, NSEC_PER_SEC);
> +
> +	local_irq_save(flags);
> +	val = FIELD_GET(MX3_PWMSR_FIFOAV, readl_relaxed(imx->mmio_base + MX3_PWMSR));
> +
> +	if (duty_cycles < imx->duty_cycle && (cr & MX3_PWMCR_EN)) {

I think you can use state->enabled instead of (cr & MX3_PWMCR_EN).