[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANiq72=QimAkV0_n2nDiPSXT0N3sWxVeapze9FPPhirmoagbug@mail.gmail.com>
Date: Wed, 9 Oct 2024 14:42:49 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: rust-for-linux@...r.kernel.org, Daniel Gomez <da.gomez@...sung.com>,
Fiona Behrens <me@...enk.dev>, Masahiro Yamada <masahiroy@...nel.org>,
Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
"David S. Miller" <davem@...emloft.net>, Kris Van Hees <kris.van.hees@...cle.com>,
Íñigo Huguet <ihuguet@...hat.com>,
Thomas Weißschuh <linux@...ssschuh.net>,
Vegard Nossum <vegard.nossum@...cle.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>, linux-kernel@...r.kernel.org,
linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] rust: query the compiler for dylib path
On Wed, Oct 9, 2024 at 12:48 AM Tamir Duberstein <tamird@...il.com> wrote:
>
> Rust proc-macro crates are loaded by the compiler at compile-time, so
> are always dynamic libraries; on macOS, these artifacts get a .dylib
> extension rather than .so.
What is the status of the macOS build support? A link would be nice here.
> Signed-off-by: Fiona Behrens <me@...enk.dev>
Is this patch Fiona's/yours/both? Depending on that, different tags
are needed here (including `From:`). Please see:
https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
> @@ -9,6 +9,8 @@ import logging
> import os
> import pathlib
> import sys
> +import os
> +import subprocess
Nit: double import, unsorted.
Thanks!
Cheers,
Miguel
Powered by blists - more mailing lists