linux-kernel - Re: [PATCH 2/2] serial: 8250_omap: mark the serial as on the wakeup path if no_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff50edb8-ec36-4cf4-b7d3-21ec01f6ff0a@bootlin.com>
Date: Wed, 9 Oct 2024 14:59:42 +0200
From: Thomas Richard <thomas.richard@...tlin.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
 Santosh Shilimkar <ssantosh@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, u-kumar1@...com, tony@...mide.com,
 khilman@...nel.org, gregory.clement@...tlin.com,
 thomas.petazzoni@...tlin.com, theo.lebrun@...tlin.com,
 richard.genoud@...tlin.com
Subject: Re: [PATCH 2/2] serial: 8250_omap: mark the serial as on the wakeup
 path if no_console_suspend

On 10/9/24 14:39, Ulf Hansson wrote:
> On Wed, 9 Oct 2024 at 14:17, Thomas Richard <thomas.richard@...tlin.com> wrote:
>>
>> On 10/9/24 12:50, Ulf Hansson wrote:
>>> On Tue, 8 Oct 2024 at 11:34, Thomas Richard <thomas.richard@...tlin.com> wrote:
>>>>
>>>> If the console suspend is disabled, mark the serial as on the wakeup path
>>>> to keep its PM domain powered on.
>>>>
>>>> Suggested-by: Théo Lebrun <theo.lebrun@...tlin.com>
>>>> Signed-off-by: Thomas Richard <thomas.richard@...tlin.com>
>>>> ---
>>>>  drivers/tty/serial/8250/8250_omap.c | 8 ++++++--
>>>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
>>>> index 88b58f44e4e9..6764fe2f9cad 100644
>>>> --- a/drivers/tty/serial/8250/8250_omap.c
>>>> +++ b/drivers/tty/serial/8250/8250_omap.c
>>>> @@ -1660,8 +1660,12 @@ static int omap8250_suspend(struct device *dev)
>>>>         if (!device_may_wakeup(dev))
>>>>                 priv->wer = 0;
>>>>         serial_out(up, UART_OMAP_WER, priv->wer);
>>>> -       if (uart_console(&up->port) && console_suspend_enabled)
>>>> -               err = pm_runtime_force_suspend(dev);
>>>> +       if (uart_console(&up->port)) {
>>>> +               if (console_suspend_enabled)
>>>> +                       err = pm_runtime_force_suspend(dev);
>>>> +               else
>>>> +                       device_set_wakeup_path(dev);
>>>> +       }
>>>
>>> Isn't this already managed by the serial core? See commit a47cf07f60dc
>>> ("serial: core: Call device_set_awake_path() for console port")
>>
>> Yes you're right.
>> So this patch is useless.
> 
> So patch 1/2 is all you need to get things working?

Yes only patch 1/2 is needed.

Regards,

Thomas