linux-kernel - Re: [PATCH net-next] tipc: Return -EINVAL on error from addr2str() methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25f50405-e36c-44a3-8045-3cc569b37a1e@redhat.com>
Date: Thu, 10 Oct 2024 11:39:24 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Shigeru Yoshida <syoshida@...hat.com>, jmaloy@...hat.com,
 ying.xue@...driver.com
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 tipc-discussion@...ts.sourceforge.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, tung.q.nguyen@...ava.com
Subject: Re: [PATCH net-next] tipc: Return -EINVAL on error from addr2str()
 methods

On 10/8/24 16:24, Shigeru Yoshida wrote:
> The return value 1 on error of the addr2str() methods are not
> descriptive. Return -EINVAL instead.
> 
> Signed-off-by: Shigeru Yoshida <syoshida@...hat.com>

I'm sorry if I gave conflicting advice in the past, but I now think this 
patch falls under the 'small cleanup patches' category we are actively 
discouraging outside the scope of a wider (functional) change:

https://lore.kernel.org/netdev/20241009-doc-mc-clean-v2-1-e637b665fa81@kernel.org/

Thanks,

Paolo