linux-kernel - Re: [PATCH v3] alienware-wmi: Dell AWCC platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4746132-2282-3cb4-64f5-bc83afbcafae@linux.intel.com>
Date: Thu, 10 Oct 2024 12:46:35 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Kurt Borja <kuurtb@...il.com>
cc: oe-kbuild-all@...ts.linux.dev, kernel test robot <lkp@...el.com>, 
    Hans de Goede <hdegoede@...hat.com>, LKML <linux-kernel@...r.kernel.org>, 
    platform-driver-x86@...r.kernel.org, Dell.Client.Kernel@...l.com
Subject: Re: [PATCH v3] alienware-wmi: Dell AWCC platform_profile support

On Thu, 10 Oct 2024, kernel test robot wrote:

> Hi Kurt,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v6.12-rc2 next-20241009]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Kurt-Borja/alienware-wmi-Dell-AWCC-platform_profile-support/20241009-040025
> base:   linus/master
> patch link:    https://lore.kernel.org/r/20241008195642.36677-2-kuurtb%40gmail.com
> patch subject: [PATCH v3] alienware-wmi: Dell AWCC platform_profile support
> config: i386-randconfig-r051-20241010 (https://download.01.org/0day-ci/archive/20241010/202410101120.w4OLAnaI-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241010/202410101120.w4OLAnaI-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410101120.w4OLAnaI-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/platform/x86/dell/alienware-wmi.c:822:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      822 |         return FIELD_PREP(PROFILE_MASK, prof) | PROFILE_ACTIVATE;
>          |                ^
>    1 error generated.
> 
> 
> vim +/FIELD_PREP +822 drivers/platform/x86/dell/alienware-wmi.c
> 
>    819	
>    820	static u32 profile_to_wmax_arg(enum WMAX_THERMAL_PROFILE prof)
>    821	{
>  > 822		return FIELD_PREP(PROFILE_MASK, prof) | PROFILE_ACTIVATE;
>    823	}
>    824	

For the one time I forget to mention that please add the necessary 
headers, it immediately bites (that was in my mind at one point but in 
the end I forgot to add it).

So please, add the headers both for FIELD_PREP() and GENMASK().

-- 
 i.