linux-kernel - Re: [PATCH 1/2] dt-bindings: serial: snps-dw-apb-uart: Add Sophgo SG2044 uarts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vinnmu45snxveh6f3emo7nhom6s2z5d7hf5pzeozyowfa3twt7@ykeidfboxfiv>
Date: Fri, 11 Oct 2024 09:11:37 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Inochi Amaoto <inochiama@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, Chen Wang <unicorn_wang@...look.com>, 
	Inochi Amaoto <inochiama@...look.com>, Yixun Lan <dlan@...too.org>, linux-kernel@...r.kernel.org, 
	linux-serial@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: serial: snps-dw-apb-uart: Add Sophgo
 SG2044 uarts

On Thu, Oct 10, 2024 at 05:54:48PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 10, 2024 at 04:23:05PM +0800, Inochi Amaoto wrote:
> > On Thu, Oct 10, 2024 at 08:12:41AM +0200, Krzysztof Kozlowski wrote:
> > > On Thu, Oct 10, 2024 at 07:39:05AM +0800, Inochi Amaoto wrote:
> > > > Add compatibles string for the Sophgo SG2044 uarts.
> > > 
> > > This we see from the diff, say something about hardware.
> > 
> > The reason for this compatiable (and the hardware) is mainly in the
> > next patch. Will it be better to submit a new verion with improved
> > description? If so, I wonder whether I can reserve your ack.
> > 
> > > I would just add it to starfive enum, but this is fine as well.
> 
> Even after reading the second patch I don't understand why you shouldn't re-use
> the starfive compatible or make a new one that covers this quirk? At least I would
> see that as second patch is basically not needed.
> 

I do not think it is good to re-use the starfive compatible, it is weird
that a sophgo SoC has a peripheral on the statfive SoC. Another suggestion
for adding a new one that covers the quirk is a good idea for me, but I am
not sure whether it may cause some misunderstanding like reuse the starfive
compatible. If the second one is possible, it is OK for me to drop the second
patch.

Regard,
Inochi