linux-kernel - Re: [PATCH v6 3/8] dt-bindings: PCI: qcom,pcie-x1e80100: Add 'global' interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <937d3d61-482a-4a14-a594-615f10baf5f0@kernel.org>
Date: Fri, 11 Oct 2024 16:36:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Qiang Yu <quic_qianyu@...cinc.com>
Cc: manivannan.sadhasivam@...aro.org, vkoul@...nel.org, kishon@...nel.org,
 robh@...nel.org, andersson@...nel.org, konradybcio@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, mturquette@...libre.com,
 sboyd@...nel.org, abel.vesa@...aro.org, quic_msarkar@...cinc.com,
 quic_devipriy@...cinc.com, dmitry.baryshkov@...aro.org, kw@...ux.com,
 lpieralisi@...nel.org, neil.armstrong@...aro.org,
 linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v6 3/8] dt-bindings: PCI: qcom,pcie-x1e80100: Add 'global'
 interrupt

On 11/10/2024 16:33, Krzysztof Kozlowski wrote:
> On Fri, Oct 11, 2024 at 03:41:37AM -0700, Qiang Yu wrote:
>> Document 'global' SPI interrupt along with the existing MSI interrupts so
>> that QCOM PCIe RC driver can make use of it to get events such as PCIe
>> link specific events, safety events, etc.
> 
> Describe the hardware, not what the driver will do.
> 
>>
>> Though adding a new interrupt will break the ABI, it is required to
>> accurately describe the hardware.
> 
> That's poor reason. Hardware was described and missing optional piece
> (because according to your description above everything was working
> fine) is not needed to break ABI.
> 
> Sorry, if your driver changes the ABI for this poor reason.
> 
> NAK.
> 

Plus you did not test DTS, not fixed existing users.

That's v6, so we assume you already know how to test it and do the
testing before posting new versions.

Best regards,
Krzysztof