linux-kernel - Aw: Re: [PATCH v4 3/4] dt-bindings: pinctrl: add binding for MT7988 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-a263618e-97dc-4b69-bc58-577ddc6b6b6c-1728657542941@3c-app-gmx-bs32>
Date: Fri, 11 Oct 2024 16:39:02 +0200
From: Frank Wunderlich <frank-w@...lic-files.de>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Frank Wunderlich <linux@...web.de>,
 linux-arm-kernel@...ts.infradead.org, Linus Walleij
 <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, eladwf@...il.com,
 Conor Dooley <conor+dt@...nel.org>, john@...ozen.org,
 linux-mediatek@...ts.infradead.org, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Matthias Brugger
 <matthias.bgg@...il.com>, devicetree@...r.kernel.org, ansuelsmth@...il.com,
 linux-gpio@...r.kernel.org, daniel@...rotopia.org, Sean Wang
 <sean.wang@...nel.org>
Subject: Aw: Re: [PATCH v4 3/4] dt-bindings: pinctrl: add binding for MT7988
 SoC


> Gesendet: Mittwoch, 09. Oktober 2024 um 23:19 Uhr
> Von: "Rob Herring (Arm)" <robh@...nel.org>
> Betreff: Re: [PATCH v4 3/4] dt-bindings: pinctrl: add binding for MT7988 SoC
>
>
> On Wed, 09 Oct 2024 18:52:13 +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@...lic-files.de>
> >
> > This adds bindings for MT7988 pinctrl driver.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> > ---
> > changes in v4:
> > - dt-binding: pinctrl: fix dt_binding_check fixed-string error
> >
> > '^mux$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#@]+\\$$'}
> > 	hint: Fixed strings belong in 'properties', not 'patternProperties'
> >
> > changes in v3:
> > - limit conf subnode name with optional suffix like mmc on mt7986
> > - match mux subnode without wildcards
> >
> > changes in v2:
> > - drop gpio-cells description
> > - move ref in mux subnode up
> > - order uart-functions alphanumeric and fix typo
> > ---
> >  .../pinctrl/mediatek,mt7988-pinctrl.yaml      | 571 ++++++++++++++++++
> >  1 file changed, 571 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml
> >
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>
Hi Rob,

thank you for RB,

i would change the drive-strength in the example also to 8 based on angelos [1] review in next version

+        mdio0_pins: mdio0-pins {
+          mux {
+            function = "eth";
+            groups = "mdc_mdio0";
+          };
+
+          conf {
+            pins = "SMI_0_MDC", "SMI_0_MDIO";
+            drive-strength = <MTK_DRIVE_8mA>;
+          };
+        };

to

+        mdio0_pins: mdio0-pins {
+          mux {
+            function = "eth";
+            groups = "mdc_mdio0";
+          };
+
+          conf {
+            pins = "SMI_0_MDC", "SMI_0_MDIO";
+            drive-strength = <8>;
+          };
+        };

can i leave your RB (so you do not need to look at it again) or drop it because i change the patch?

regards Frank

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20241009165222.5670-5-linux@fw-web.de/#26062582