linux-kernel - Re: [PATCH] ASoC: qcom: sdm845: add missing soundwire runtime stream alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D4T37UMU6SH0.1IFHCFVO3UJ7L@linaro.org>
Date: Fri, 11 Oct 2024 16:38:21 +0100
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
 <linux-sound@...r.kernel.org>, <srinivas.kandagatla@...aro.org>,
 <linux-arm-msm@...r.kernel.org>
Cc: <stable@...r.kernel.org>, <broonie@...nel.org>,
 <dmitry.baryshkov@...aro.org>, <pierre-louis.bossart@...ux.intel.com>,
 <vkoul@...nel.org>, <lgirdwood@...il.com>, <perex@...ex.cz>,
 <tiwai@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: qcom: sdm845: add missing soundwire runtime
 stream alloc

On Thu Oct 10, 2024 at 6:18 AM BST, Krzysztof Kozlowski wrote:
> On 09/10/2024 23:39, Alexey Klimov wrote:
> > During the migration of Soundwire runtime stream allocation from
> > the Qualcomm Soundwire controller to SoC's soundcard drivers the sdm845
> > soundcard was forgotten.
> > 
> > At this point any playback attempt or audio daemon startup, for instance
> > on sdm845-db845c (Qualcomm RB3 board), will result in stream pointer
> > NULL dereference:
>
> ...
>
> > 
> > Reproduced and then fix was tested on db845c RB3 board.
> > 
> > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > Cc: stable@...r.kernel.org
> > Fixes: 15c7fab0e047 ("ASoC: qcom: Move Soundwire runtime stream alloc to soundcards")
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> > Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> > ---
>
> We should fix this everywhere, not only sdm845. I'll look at remaining
> sc7280.

What about sc7180? Or is sc7180 one the platforms where soundwire is not used
and DSP is not involved?
Anyway, I don't have hw to test sc7180 or sc7280.

Thank you,
Alexey