linux-kernel - Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7df1961f-f120-3914-ef23-9e466cda6248@amd.com>
Date: Fri, 11 Oct 2024 11:55:14 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: Pavan Kumar Paluri <papaluri@....com>, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-coco@...ts.linux.dev,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Eric Van Tassell <Eric.VanTassell@....com>,
 Ashish Kalra <ashish.kalra@....com>, Michael Roth <michael.roth@....com>,
 "H . Peter Anvin" <hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>,
 Dhaval Giani <dhaval.giani@....com>
Subject: Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into
 arch/x86/virt/svm

On 10/11/24 11:48, Borislav Petkov wrote:
> On Fri, Oct 11, 2024 at 11:35:40AM -0500, Tom Lendacky wrote:
>> But the patch includes the new file, so how can that be?
> 
> Ah, wrong error, sorry.
> 
> This is his error:
> 
> arch/x86/virt/svm/cmdline.c:15:27: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__read_mostly’
>    15 | struct sev_config sev_cfg __read_mostly;
>       |                           ^~~~~~~~~~~~~
> make[5]: *** [scripts/Makefile.build:229: arch/x86/virt/svm/cmdline.o] Error 1
> make[4]: *** [scripts/Makefile.build:478: arch/x86/virt/svm] Error 2
> make[3]: *** [scripts/Makefile.build:478: arch/x86/virt] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [scripts/Makefile.build:478: arch/x86] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/mnt/kernel/kernel/2nd/linux/Makefile:1936: .] Error 2
> make: *** [Makefile:224: __sub-make] Error 2

Ah, that makes more sense. Looks like he's missing the include for
linux/cache.h

Thanks,
Tom

>