[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZwlfENV_ijDKjUqW@agluck-desk3.sc.intel.com>
Date: Fri, 11 Oct 2024 10:23:28 -0700
From: Tony Luck <tony.luck@...el.com>
To: Babu Moger <babu.moger@....com>
Cc: corbet@....net, fenghua.yu@...el.com, reinette.chatre@...el.com,
tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
paulmck@...nel.org, rdunlap@...radead.org, tj@...nel.org,
peterz@...radead.org, yanjiewtw@...il.com, kim.phillips@....com,
lukas.bulwahn@...il.com, seanjc@...gle.com, jmattson@...gle.com,
leitao@...ian.org, jpoimboe@...nel.org, rick.p.edgecombe@...el.com,
kirill.shutemov@...ux.intel.com, jithu.joseph@...el.com,
kai.huang@...el.com, kan.liang@...ux.intel.com,
daniel.sneddon@...ux.intel.com, pbonzini@...hat.com,
sandipan.das@....com, ilpo.jarvinen@...ux.intel.com,
peternewman@...gle.com, maciej.wieczor-retman@...el.com,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
eranian@...gle.com, james.morse@....com
Subject: Re: [PATCH v8 20/25] x86/resctrl: Report "Unassigned" for MBM events
in mbm_cntr_assign mode
On Wed, Oct 09, 2024 at 12:39:45PM -0500, Babu Moger wrote:
> @@ -576,6 +576,15 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg)
> evtid = md.u.evtid;
> r = &rdt_resources_all[resid].r_resctrl;
>
> + if (resctrl_arch_mbm_cntr_assign_enabled(r) && evtid != QOS_L3_OCCUP_EVENT_ID) {
Better to write this as:
if (resctrl_arch_mbm_cntr_assign_enabled(r) && is_mbm_event(evtid)) {
-Tony
Powered by blists - more mailing lists