linux-kernel - Re: [PATCH 1/3 v2] nvme: make independent ns identify default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <455d17f6-ec55-4bce-b9d3-9f43eb4a056a@app.fastmail.com>
Date: Fri, 11 Oct 2024 20:32:23 +0300
From: Matias Bjørling <m@...rling.me>
To: "Christoph Hellwig" <hch@....de>
Cc: kbusch@...nel.org, dlemoal@...nel.org, cassel@...nel.org,
 linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, wangyugui@...-tech.com,
 martin.petersen@...cle.com, hare@...e.de,
 Matias Bjørling <matias.bjorling@....com>
Subject: Re: [PATCH 1/3 v2] nvme: make independent ns identify default

On Fri, Oct 11, 2024, at 11:14, Christoph Hellwig wrote:
> On Thu, Oct 10, 2024 at 02:39:49PM +0200, Matias Bjørling wrote:
>> From: Matias Bjørling <matias.bjorling@....com>
>> 
>> The NVMe 2.0 specification adds an independent identify namespace
>> data structure that contains generic attributes that apply to all
>> namespace types. Some attributes carry over from the NVM command set
>> identify namespace data structure, and others are new.
>> 
>> Currently, the data structure only considered when CRIMS is enabled or
>> when the namespace type is key-value.
>> 
>> However, the independent namespace data structure
>> is mandatory for devices that implement features from the 2.0+
>> specification. Therefore, we can check this data structure first. If
>> unavailable, retrieve the generic attributes from the NVM command set
>> identify namespace data structure.
>
> FYI, I still disagree with this for the same reason as before.
> Assuming we're not really going to see hard drivers I'd be fine
> with using it by default for 2.0 (or better even 2.1) by default.

Sounds good. When I am back after next week, I'll update the patch set with the version check and add the missing logic for hdd support. 

(Apologies for double e-mail. My phone client formatted the mail in html)