linux-kernel - Re: [PATCH RESEND] clocksource/drivers/timer-ti-dm: Don't fail probe if int not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71eab373-00cc-49ca-878c-d43182c918e4@ti.com>
Date: Fri, 11 Oct 2024 12:39:05 -0500
From: Judith Mendez <jm@...com>
To: Bryan Brattlof <bb@...com>
CC: Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner
	<tglx@...utronix.de>, <linux-kernel@...r.kernel.org>,
        Vignesh Raghavendra
	<vigneshr@...com>
Subject: Re: [PATCH RESEND] clocksource/drivers/timer-ti-dm: Don't fail probe
 if int not found

Hi Bryan,

On 10/10/24 4:18 PM, Bryan Brattlof wrote:
> On October 10, 2024 thus sayeth Judith Mendez:
>> Some timers may not have an interrupt routed to
>> the A53 GIC, but the timer PWM functionality can still
>> be used by Linux Kernel. Therefore, do not fail probe
>> if interrupt is not found and ti,timer-pwm exists.
>>
>> Fixes: df28472a1b28 ("ARM: OMAP: dmtimer: platform driver")
>> Signed-off-by: Judith Mendez <jm@...com>
>> ---
>> Changes since v1:
>> - Rebased, add to CC list, add fixes tag
>> ---
>>   drivers/clocksource/timer-ti-dm.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
>> index b7a34b1a975e..1b61fefed213 100644
>> --- a/drivers/clocksource/timer-ti-dm.c
>> +++ b/drivers/clocksource/timer-ti-dm.c
>> @@ -1104,8 +1104,12 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
>>   		return  -ENOMEM;
>>   
>>   	timer->irq = platform_get_irq(pdev, 0);
>> -	if (timer->irq < 0)
>> -		return timer->irq;
>> +	if (timer->irq < 0) {
>> +		if (of_property_read_bool(dev->of_node, "ti,timer-pwm"))
>> +			dev_err(dev, "Did not find timer interrupt, timer usable in PWM mode only\n");
> 
> Is this really an error? or more of a dev_info() type problem. It looks
> like we changed how we integrated the timer in K3 chips that broke some
> assumptions made in OMAP.

I can switch to dev_info() no problem, thanks for reviewing!

~ Judith

> 
> ~Bryan