linux-kernel - Re: [PATCH v2 rcu 13/13] srcu: Improve srcu_read_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYOdvO_PY-QZySa1qtWqZ_+1zySrw+0Qo1cc9HL5=L4aA@mail.gmail.com>
Date: Fri, 11 Oct 2024 10:57:13 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: "Paul E. McKenney" <paulmck@...nel.org>
Cc: frederic@...nel.org, rcu@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-team@...a.com, rostedt@...dmis.org, 
	Andrii Nakryiko <andrii@...nel.org>
Subject: Re: [PATCH v2 rcu 13/13] srcu: Improve srcu_read_lock_lite()
 kernel-doc comment

On Fri, Oct 11, 2024 at 10:39 AM Paul E. McKenney <paulmck@...nel.org> wrote:
>
> Where RCU is watching is where it is OK to invoke rcu_read_lock().
>
> Reported-by: Andrii Nakryiko <andrii@...nel.org>
> Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> ---
>  include/linux/srcu.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Acked-by: Andrii Nakryiko <andrii@...nel.org>

> diff --git a/include/linux/srcu.h b/include/linux/srcu.h
> index 4ba96e2cfa405..bab1dae3f69e6 100644
> --- a/include/linux/srcu.h
> +++ b/include/linux/srcu.h
> @@ -270,7 +270,8 @@ static inline int srcu_read_lock(struct srcu_struct *ssp) __acquires(ssp)
>   * synchronize_rcu_expedited(), IPIs and all.
>   *
>   * Note that srcu_read_lock_lite() can be invoked only from those contexts
> - * where RCU is watching.  Otherwise, lockdep will complain.
> + * where RCU is watching, that is, from contexts where it would be legal
> + * to invoke rcu_read_lock().  Otherwise, lockdep will complain.
>   */
>  static inline int srcu_read_lock_lite(struct srcu_struct *ssp) __acquires(ssp)
>  {
> --
> 2.40.1
>