[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zwl0jmF093JHb2aE@vamoirid-laptop>
Date: Fri, 11 Oct 2024 20:55:10 +0200
From: Vasileios Aoiridis <vassilisamir@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, anshulusr@...il.com, gustavograzs@...il.com,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 07/13] iio: chemical: bme680: add regulators
On Fri, Oct 11, 2024 at 01:05:06PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 10, 2024 at 11:00:24PM +0200, vamoirid wrote:
> > From: Vasileios Amoiridis <vassilisamir@...il.com>
> >
> > Add support for the regulators described in the dt-binding.
>
> ...
>
> > +static const char *const bme680_supply_names[] = {
> > + "vdd", "vddio"
>
> Leave trailing comma.
>
ACK.
> > +};
>
> ...
>
> > + devm_add_action_or_reset(dev, bme680_regulators_disable, data->supplies);
>
> No error check?! Why?
>
You are right, I should put it, I probably didnit see it!
> --
> With Best Regards,
> Andy Shevchenko
>
>
Cheers,
Vasilis
Powered by blists - more mailing lists