linux-kernel - Re: [PATCH v1 09/13] iio: chemical: bme680: Move ambient temperature to attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zwl2mIWP22MiwG4T@vamoirid-laptop>
Date: Fri, 11 Oct 2024 21:03:52 +0200
From: Vasileios Aoiridis <vassilisamir@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, anshulusr@...il.com, gustavograzs@...il.com,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 09/13] iio: chemical: bme680: Move ambient temperature
 to attributes

On Fri, Oct 11, 2024 at 01:12:21PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 10, 2024 at 11:00:26PM +0200, vamoirid wrote:
> > From: Vasileios Amoiridis <vassilisamir@...il.com>
> > 
> > Remove the ambient temperature from being a macro and implement it as
> > an attribute. This way, it is possible to dynamically configure the
> > ambient temperature of the environment to improve the accuracy of the
> > measurements.
> 
> ...
> 
> > -	var1 = (((s32)BME680_AMB_TEMP * calib->par_gh3) / 1000) * 256;
> > +	var1 = (((s32)data->ambient_temp * calib->par_gh3) / 1000) * 256;
> 
> MILLI? KILO?
>

I could do it yes.

> ...
> 
> >  static struct attribute *bme680_attributes[] = {
> >  	&iio_const_attr_oversampling_ratio_available.dev_attr.attr,
> > +	&iio_dev_attr_ambient_temp.dev_attr.attr,
> >  	NULL,
> 
> Side note: Perhaps a patch or an additional change in the existing one to drop
> the trailing comma here.
> 

I could add an additional change if you think it is worth the churn.

> >  };
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Cheers,
Vasilis