linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eknpk3z3isudjqa2a74cqvicrthjs6us7gx7z3itox4utkpobr@cxbxkx5h64x5>
Date: Sat, 12 Oct 2024 00:37:54 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jonathan Marek <jonathan@...ek.ca>
Cc: linux-arm-msm@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb
 ports

On Fri, Oct 11, 2024 at 11:27:11AM -0400, Jonathan Marek wrote:
> The 3 USB ports on x1e80100-crd are OTG-capable, change dr_mode and add
> usb-role-switch flag to enable OTG.
> 
> Signed-off-by: Jonathan Marek <jonathan@...ek.ca>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> index 6dfc85eda3540..53e76b3f0c831 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> @@ -1558,7 +1558,8 @@ &usb_1_ss0 {
>  };
>  
>  &usb_1_ss0_dwc3 {
> -	dr_mode = "host";
> +	dr_mode = "otg";

There should be no need to specify "otg", it is a default if I remember
correctly.

> +	usb-role-switch;

Please move usb-role-switch to the x1e80100.dtsi instead.

>  };
>  
>  &usb_1_ss0_dwc3_hs {
> @@ -1590,7 +1591,8 @@ &usb_1_ss1 {
>  };
>  
>  &usb_1_ss1_dwc3 {
> -	dr_mode = "host";
> +	dr_mode = "otg";
> +	usb-role-switch;
>  };
>  
>  &usb_1_ss1_dwc3_hs {
> @@ -1622,7 +1624,8 @@ &usb_1_ss2 {
>  };
>  
>  &usb_1_ss2_dwc3 {
> -	dr_mode = "host";
> +	dr_mode = "otg";
> +	usb-role-switch;
>  };
>  
>  &usb_1_ss2_dwc3_hs {
> -- 
> 2.45.1
> 

-- 
With best wishes
Dmitry