[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a1acb975-c29e-4c90-b7a9-5f50478ab946@amd.com>
Date: Fri, 11 Oct 2024 08:35:55 +0530
From: "Lazar, Lijo" <lijo.lazar@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Hawking Zhang <Hawking.Zhang@....com>,
Yunxiang Li <Yunxiang.Li@....com>,
Srinivasan Shanmugam <srinivasan.shanmugam@....com>,
"Dr. David Alan Gilbert" <linux@...blig.org>,
Rajneesh Bhardwaj <rajneesh.bhardwaj@....com>,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm/amdgpu: Fix off by one in
current_memory_partition_show()
On 10/11/2024 12:05 AM, Dan Carpenter wrote:
> The >= ARRAY_SIZE() should be > ARRAY_SIZE() to prevent an out of
> bounds read.
>
> Fixes: 012be6f22c01 ("drm/amdgpu: Add sysfs interfaces for NPS mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
Reviewed-by: Lijo Lazar <lijo.lazar@....com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index ddf716d27f3a..75c9291ac3eb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -1199,7 +1199,7 @@ static ssize_t current_memory_partition_show(
> enum amdgpu_memory_partition mode;
>
> mode = adev->gmc.gmc_funcs->query_mem_partition_mode(adev);
> - if ((mode > ARRAY_SIZE(nps_desc)) ||
> + if ((mode >= ARRAY_SIZE(nps_desc)) ||
> (BIT(mode) & AMDGPU_ALL_NPS_MASK) != BIT(mode))
> return sysfs_emit(buf, "UNKNOWN\n");
>
Powered by blists - more mailing lists