linux-kernel - Re: [RESEND PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABQX2QP5HdCkfffiLGHUm16OT3_c_5LOzwfNv-gxs0ZxZVyGmQ@mail.gmail.com>
Date: Thu, 10 Oct 2024 23:11:19 -0400
From: Zack Rusin <zack.rusin@...adcom.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree()

On Mon, Oct 7, 2024 at 7:52 AM Thorsten Blum <thorsten.blum@...ux.dev> wrote:
>
> Since kvfree() already checks if its argument is NULL, an additional
> check before calling kvfree() is unnecessary and can be removed.
>
> Remove both and the following Coccinelle/coccicheck warnings reported by
> ifnullfree.cocci:
>
>   WARNING: NULL check before some freeing functions is not needed
>   WARNING: NULL check before some freeing functions is not needed
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> index 890a66a2361f..64bd7d74854e 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> @@ -635,10 +635,8 @@ int vmw_bo_cpu_blit(struct vmw_bo *vmw_dst,
>                 kunmap_atomic(d.src_addr);
>         if (d.dst_addr)
>                 kunmap_atomic(d.dst_addr);
> -       if (src_pages)
> -               kvfree(src_pages);
> -       if (dst_pages)
> -               kvfree(dst_pages);
> +       kvfree(src_pages);
> +       kvfree(dst_pages);
>
>         return ret;
>  }
> --
> 2.46.2
>

Thank you. Looks good. I went ahead and pushed it to drm-misc-fixes.

z