linux-kernel - Re: [PATCH v5 02/10] iio: dac: adi-axi-dac: update register names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34ce8e9c13a3680c7a3ab44e5c91ab80042ad009.camel@gmail.com>
Date: Fri, 11 Oct 2024 08:47:00 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Angelo Dureghello <adureghello@...libre.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich	
 <Michael.Hennerich@...log.com>, Nuno Sa <nuno.sa@...log.com>, Jonathan
 Cameron	 <jic23@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Olivier Moysan	 <olivier.moysan@...s.st.com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, 	linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, 	devicetree@...r.kernel.org,
 dletchner@...libre.com, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v5 02/10] iio: dac: adi-axi-dac: update register names

On Thu, 2024-10-10 at 19:52 +0200, Angelo Dureghello wrote:
> Hi Nuno,
> 
> On 10.10.2024 14:59, Nuno Sá wrote:
> > On Tue, 2024-10-08 at 17:43 +0200, Angelo Dureghello wrote:
> > > From: Angelo Dureghello <adureghello@...libre.com>
> > > 
> > > Non functional, readability change.
> > > 
> > > Update register names so that register bitfields can be more easily
> > > linked to the register name.
> > > 
> > > Signed-off-by: Angelo Dureghello <adureghello@...libre.com>
> > > ---
> > 
> > I don't fully agree that this is so much better that's worth the churn...
> > 
> > From a quick a look I saw (I think) some defines where _REG seems to be
> > missing.
> > Those is fine to change for consistency but I don't really seeing the big
> > benefit in changing them all.
> > 
> > (Sorry for only complaining in v5 about this...)
> > 
> 
> no problem,
> 
> the change was suggested from Jonathan, was not something i need, 
> let's see if he has further feedbacks, in case i can roll back
> easily.
> 

Oh, I see... Well, still don't think it's worth the churn but he has the last
word on this :)

- Nuno Sá