linux-kernel - Re: [PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af81be27-fdfa-4dec-a18c-56c7022e3c75@kernel.org>
Date: Fri, 11 Oct 2024 08:48:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Qingqing Zhou <quic_qqzhou@...cinc.com>, andersson@...nel.org,
 konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, robimarko@...il.com, quic_gurus@...cinc.com,
 will@...nel.org, robin.murphy@....com, joro@...tes.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, iommu@...ts.linux.dev
Subject: Re: [PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps
 smmu

On 11/10/2024 08:31, Qingqing Zhou wrote:
> Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function
> is required by multiple functions including USB/UFS/Ethernet.

Do not explain what SMMU is, because it is obvious, but explain how this
hardware differs from everything existing.

> 
> Signed-off-by: Qingqing Zhou <quic_qqzhou@...cinc.com>
> ---
>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 92d350b8e01a..9e62c2cdda08 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -36,6 +36,7 @@ properties:
>          items:
>            - enum:
>                - qcom,qcm2290-smmu-500
> +              - qcom,qcs615-smmu-500

This is incomplete? No clocks? No power-domains?

Best regards,
Krzysztof