linux-kernel - Re: [PATCH v4 5/5] usb: host: enable sideband transfer during system sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOuDEK1RGgOTWF3ja+UaAYzMbDU0kJ0GQ7b+wjSQVjr1Fo=40A@mail.gmail.com>
Date: Fri, 11 Oct 2024 15:34:00 +0800
From: Guan-Yu Lin <guanyulin@...gle.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Thinh.Nguyen@...opsys.com, mathias.nyman@...el.com, 
	stern@...land.harvard.edu, elder@...nel.org, oneukum@...e.com, 
	yajun.deng@...ux.dev, dianders@...omium.org, kekrby@...il.com, perex@...ex.cz, 
	tiwai@...e.com, tj@...nel.org, stanley_chang@...ltek.com, 
	andreyknvl@...il.com, christophe.jaillet@...adoo.fr, 
	quic_jjohnson@...cinc.com, ricardo@...liere.net, grundler@...omium.org, 
	niko.mauno@...sala.com, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org, badhri@...gle.com, 
	albertccwang@...gle.com, quic_wcheng@...cinc.com, pumahsu@...gle.com
Subject: Re: [PATCH v4 5/5] usb: host: enable sideband transfer during system sleep

On Wed, Oct 9, 2024 at 8:47 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Wed, Oct 09, 2024 at 05:42:59AM +0000, Guan-Yu Lin wrote:
> > @@ -1583,6 +1583,11 @@ int usb_suspend(struct device *dev, pm_message_t msg)
> >       struct usb_device       *udev = to_usb_device(dev);
> >       int r;
> >
> > +     if (msg.event == PM_EVENT_SUSPEND && usb_sideband_check(udev)) {
> > +             dev_info(dev, "device active, skip %s", __func__);
>
> When drivers work properly, they are quiet.  Why all of the loud
> shouting in this patch as it goes about it's business?
>
> also, __func__ is redundant in dev_*() calls :)
>
> thanks,
>
> greg k-h

Thanks for the suggestions. Let me switch to dev_dbg and remove
__func__ in the next patch.

Regards,
Guan-Yu