linux-kernel - Re: [PATCH] um: Abandon the _PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99d9e95fcb27160da5ff931fcfe16a07b3256574.camel@sipsolutions.net>
Date: Fri, 11 Oct 2024 09:38:29 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Tiwei Bie <tiwei.btw@...group.com>, richard@....at, 
	anton.ivanov@...bridgegreys.com
Cc: linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: Abandon the _PAGE_NEWPROT bit

Hi Tiwei,

So kind of a nit, but if the resulting code looks like this:

> @@ -184,17 +172,14 @@ static inline pte_t pte_wrprotect(pte_t pte)
>  {
>  	if (likely(pte_get_bits(pte, _PAGE_RW)))
>  		pte_clear_bits(pte, _PAGE_RW);
> 	return pte;
>  }

then the if really isn't needed?

Same for all the others, I guess.

johannes