linux-kernel - Re: [PATCH v9 1/4] Consolidate IO memcpy/memset into iomem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwjYfUrHfZlxBVxQ@infradead.org>
Date: Fri, 11 Oct 2024 00:49:17 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Julian Vetter <jvetter@...rayinc.com>
Cc: Arnd Bergmann <arnd@...db.de>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Guo Ren <guoren@...nel.org>,
	Huacai Chen <chenhuacai@...nel.org>,
	WANG Xuerui <kernel@...0n.name>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Richard Henderson <richard.henderson@...aro.org>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Takashi Iwai <tiwai@...e.com>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	David Laight <David.Laight@...lab.com>,
	Johannes Berg <johannes@...solutions.net>,
	Christoph Hellwig <hch@...radead.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-csky@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-arch@...r.kernel.org, Yann Sionneau <ysionneau@...rayinc.com>
Subject: Re: [PATCH v9 1/4] Consolidate IO memcpy/memset into iomem_copy.c

On Thu, Oct 10, 2024 at 02:36:24PM +0200, Julian Vetter wrote:
> Various architectures have almost the same implementations for
> memcpy_{to,from}io and memset_io functions. So, consolidate them
> into a common lib/iomem_copy.c.

That might be the final intent of this seris, but what this patch does is
to replace the trivial memset/memcpy inline implementations with a more 
complex one that actually use the accessors.

So this actually changes behavior for those architectures that did not
provide them before quite a lot.  You'll need to explain in more
detail why that is safe and desireable.