linux-kernel - Re: [PATCH 2/3 v2] nvme: add rotational support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241011081530.GB3337@lst.de>
Date: Fri, 11 Oct 2024 10:15:30 +0200
From: Christoph Hellwig <hch@....de>
To: Matias Bjørling <m@...rling.me>
Cc: kbusch@...nel.org, hch@....de, dlemoal@...nel.org, cassel@...nel.org,
	linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, wangyugui@...-tech.com,
	martin.petersen@...cle.com, hare@...e.de,
	Matias Bjørling <matias.bjorling@....com>
Subject: Re: [PATCH 2/3 v2] nvme: add rotational support

On Thu, Oct 10, 2024 at 02:39:50PM +0200, Matias Bjørling wrote:
> From: Wang Yugui <wangyugui@...-tech.com>
> 
> Rotational devices, such as hard-drives, can be detected using
> the rotational bit in the namespace independent identify namespace
> data structure. Make the bit visible to the block layer through the
> rotational queue setting.
> 
> Signed-off-by: Wang Yugui <wangyugui@...-tech.com>
> Reviewed-by: Matias Bjørling <matias.bjorling@....com>

If you pass this on, this should be a Signed-off-by.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

> larlar

?