linux-kernel - Re: [PATCH][next] drm/msm/a6xx: Remove logically deadcode in a6xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef752080-130f-463e-bcd4-e1a33fc962bd@stanley.mountain>
Date: Fri, 11 Oct 2024 11:19:18 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: "Everest K.C." <everestkc@...restkc.com.np>
Cc: robdclark@...il.com, sean@...rly.run, konradybcio@...nel.org,
	quic_abhinavk@...cinc.com, dmitry.baryshkov@...aro.org,
	marijn.suijten@...ainline.org, airlied@...il.com, simona@...ll.ch,
	skhan@...uxfoundation.org, linux-arm-msm@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/msm/a6xx: Remove logically deadcode in
 a6xx_preempt.c

On Thu, Oct 10, 2024 at 11:23:14PM -0600, Everest K.C. wrote:
> The ternary operator never returns -1 as `ring` will never be NULL.
> Thus, the ternary operator is not needed.
> Fix this by removing the ternary operation and only including the
> value it will return when the `ring` is not NULL.
> 
> This was reported by Coverity Scan.
> https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600286
> 
> Fixes: 35d36dc1692f ("drm/msm/a6xx: Add traces for preemption")
> Signed-off-by: Everest K.C. <everestkc@...restkc.com.np>
> ---

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter