linux-kernel - Re: [PATCH] ALSA: hda/cs8409: Fix possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87msjbm26t.wl-tiwai@suse.de>
Date: Fri, 11 Oct 2024 11:14:18 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Murad Masimov <m.masimov@...ima.ru>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Vitaly
 Rodionov <vitalyr@...nsource.cirrus.com>,
	<linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<lvc-project@...uxtesting.org>
Subject: Re: [PATCH] ALSA: hda/cs8409: Fix possible NULL dereference

On Fri, 11 Oct 2024 00:16:45 +0200,
Murad Masimov wrote:
> 
> If snd_hda_gen_add_kctl fails to allocate memory and returns NULL, then
> NULL pointer dereference will occur in the next line.
> 
> Since dolphin_fixups function is a hda_fixup function which is not supposed
> to return any errors, add simple check before dereference, ignore the fail.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 20e507724113 ("ALSA: hda/cs8409: Add support for dolphin")
> Signed-off-by: Murad Masimov <m.masimov@...ima.ru>

Thanks, applied.


Takashi