linux-kernel - Re: [PATCH v1 07/13] iio: chemical: bme680: add regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zwj4Unpcq2w7V4eq@smile.fi.intel.com>
Date: Fri, 11 Oct 2024 13:05:06 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: vamoirid <vassilisamir@...il.com>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, anshulusr@...il.com, gustavograzs@...il.com,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 07/13] iio: chemical: bme680: add regulators

On Thu, Oct 10, 2024 at 11:00:24PM +0200, vamoirid wrote:
> From: Vasileios Amoiridis <vassilisamir@...il.com>
> 
> Add support for the regulators described in the dt-binding.

...

> +static const char *const bme680_supply_names[] = {
> +	"vdd", "vddio"

Leave trailing comma.

> +};

...

> +	devm_add_action_or_reset(dev, bme680_regulators_disable, data->supplies);

No error check?! Why?

-- 
With Best Regards,
Andy Shevchenko