linux-kernel - Re: [PATCH] ALSA: core: Remove unused copy_from_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwkEhsYvaEHW_Czd@gallifrey>
Date: Fri, 11 Oct 2024 10:57:10 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Takashi Iwai <tiwai@...e.de>
Cc: perex@...ex.cz, tiwai@...e.com, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: core: Remove unused copy_from_user_toio

* Takashi Iwai (tiwai@...e.de) wrote:
> On Thu, 10 Oct 2024 22:53:40 +0200,
> linux@...blig.org wrote:
> > 
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > copy_from_user_toio() has been unused since commit
> > ce2d8ed8d809 ("ASoC: qcom: Convert to generic PCM copy ops")
> > 
> > Remove it.
> 
> It's a pair of copy_to_*(), so if any, it should be dropped only after
> both users are gone.

OK, fair enough.

Dave

> 
> thanks,
> 
> Takashi
> 
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > ---
> >  include/sound/core.h |  1 -
> >  sound/core/memory.c  | 20 --------------------
> >  2 files changed, 21 deletions(-)
> > 
> > diff --git a/include/sound/core.h b/include/sound/core.h
> > index 1f3f5dccd736..b5a6f3d2bff5 100644
> > --- a/include/sound/core.h
> > +++ b/include/sound/core.h
> > @@ -267,7 +267,6 @@ static inline int snd_minor_info_oss_init(void) { return 0; }
> >  /* memory.c */
> >  
> >  int copy_to_user_fromio(void __user *dst, const volatile void __iomem *src, size_t count);
> > -int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count);
> >  
> >  /* init.c */
> >  
> > diff --git a/sound/core/memory.c b/sound/core/memory.c
> > index 2d2d0094c897..8222a851da87 100644
> > --- a/sound/core/memory.c
> > +++ b/sound/core/memory.c
> > @@ -63,26 +63,6 @@ int copy_to_iter_fromio(struct iov_iter *dst, const void __iomem *src,
> >  }
> >  EXPORT_SYMBOL(copy_to_iter_fromio);
> >  
> > -/**
> > - * copy_from_user_toio - copy data from user-space to mmio-space
> > - * @dst: the destination pointer on mmio-space
> > - * @src: the source pointer on user-space
> > - * @count: the data size to copy in bytes
> > - *
> > - * Copies the data from user-space to mmio-space.
> > - *
> > - * Return: Zero if successful, or non-zero on failure.
> > - */
> > -int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count)
> > -{
> > -	struct iov_iter iter;
> > -
> > -	if (import_ubuf(ITER_SOURCE, (void __user *)src, count, &iter))
> > -		return -EFAULT;
> > -	return copy_from_iter_toio((void __iomem *)dst, &iter, count);
> > -}
> > -EXPORT_SYMBOL(copy_from_user_toio);
> > -
> >  /**
> >   * copy_from_iter_toio - copy data from iov_iter to mmio-space
> >   * @dst: the destination pointer on mmio-space
> > -- 
> > 2.47.0
> > 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/