linux-kernel - Re: [PATCH 7/8] staging: vchiq_core: Lower indentation in parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e57a187-acf1-40fc-a81b-5f90a12b9658@gmx.net>
Date: Fri, 11 Oct 2024 13:07:51 +0200
From: Stefan Wahren <wahrenst@....net>
To: Umang Jain <umang.jain@...asonboard.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Cc: linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH 7/8] staging: vchiq_core: Lower indentation in
 parse_open()

Am 11.10.24 um 09:22 schrieb Umang Jain:
> If the service is not in VCHIQ_SRVSTATE_LISTENING state, it is
> implied that the message is dealt with and parse_open() should return.
> If this is the case, simply jump the code flow to return site using
> 'goto done;' statement.
>
> This helps to lower the indentation of
> 	if (service->srvstate == VCHIQ_SRVSTATE_LISTENING)
> conditional branch.
>
> No functional changes intended in this patch.
>
> Signed-off-by: Umang Jain <umang.jain@...asonboard.com>
Reviewed-by: Stefan Wahren <wahrenst@....net>