linux-kernel - Re: [PATCHv6 bpf-next 15/16] selftests/bpf: Add uprobe sessions to consumer test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwkNzWPlpK4P2Iyh@krava>
Date: Fri, 11 Oct 2024 13:36:45 +0200
From: Jiri Olsa <olsajiri@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Oleg Nesterov <oleg@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
	Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
	Yonghong Song <yhs@...com>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...omium.org>,
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCHv6 bpf-next 15/16] selftests/bpf: Add uprobe sessions to
 consumer test

On Thu, Oct 10, 2024 at 07:30:19PM -0700, Andrii Nakryiko wrote:
> On Thu, Oct 10, 2024 at 1:13 PM Jiri Olsa <jolsa@...nel.org> wrote:
> >
> > Adding uprobe session consumers to the consumer test,
> > so we get the session into the test mix.
> >
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  .../bpf/prog_tests/uprobe_multi_test.c        | 63 +++++++++++++++----
> >  .../bpf/progs/uprobe_multi_consumers.c        | 16 ++++-
> >  2 files changed, 66 insertions(+), 13 deletions(-)
> >
> 
> you are undoing most of the changes done in the previous patch... it
> seems like it would be better to just combine  both patches

ok, the diff looks actualy ok, I'll squash them together

thanks,
jirka

> 
> > diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> > index 2effe4d693b4..df9314309bc3 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> > @@ -761,6 +761,10 @@ get_program(struct uprobe_multi_consumers *skel, int prog)
> >                 return skel->progs.uprobe_0;
> >         case 1:
> >                 return skel->progs.uprobe_1;
> > +       case 2:
> > +               return skel->progs.uprobe_2;
> > +       case 3:
> > +               return skel->progs.uprobe_3;
> >         default:
> >                 ASSERT_FAIL("get_program");
> >                 return NULL;
> 
> [...]