linux-kernel - Re: [PATCH] kbuild: rust: add `CONFIG_RUSTC_LLVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241011130641.4a8419c1@eugeo>
Date: Fri, 11 Oct 2024 13:06:41 +0100
From: Gary Guo <gary@...yguo.net>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: masahiroy@...nel.org, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor
 <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
 <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, Alice
 Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Nathan
 Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>,
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Petr Mladek <pmladek@...e.com>,
 Tejun Heo <tj@...nel.org>, Yoann Congal <yoann.congal@...le.fr>, Randy
 Dunlap <rdunlap@...radead.org>, Roman Gushchin <roman.gushchin@...ux.dev>,
 Jens Axboe <axboe@...nel.dk>, Jann Horn <jannh@...gle.com>, Mark Rutland
 <mark.rutland@....com>, kees@...nel.org, linux-kbuild@...r.kernel.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
 rust-for-linux@...r.kernel.org, samitolvanen@...gle.com
Subject: Re: [PATCH] kbuild: rust: add `CONFIG_RUSTC_LLVM_VERSION`

On Fri, 11 Oct 2024 13:53:47 +0200
Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:

> On Fri, Oct 11, 2024 at 1:41 PM Gary Guo <gary@...yguo.net> wrote:
> >
> > The invocation of rustc-version is being moved from init/Kconfig to
> > scripts/Kconfig.include for consistency with cc-version.  
> 
> Yeah, I am ambivalent. Dropping them would minimize changes and avoid
> introducing something only used once, which would be nice too. Happy
> either way.
> 

Another motivation is that in my helper inline series, I need to do
arithmetic on LLVM version (divide it by 10000 to get major verison),
which isn't possible for config options, but will work for variables
defiend in Kconfig.include.

I didn't mention it in the commit message for this patch because this
is not my patch series :)

Best,
Gary

> > +if output=$("$@" --version --verbose 2>/dev/null | grep LLVM); then  
> 
> Similarly, I wonder if we should use '^LLVM version: ' here or similar
> to minimize the chances the "LLVM" string appears elsewhere in the
> future (perhaps in a custom string a vendor adds, though I would
> expect them to add it lowercase). We are relying on having a $3 when
> splitting anyway.
> 
> Depending on what Masahiro prefers, I will take this one or the
> one-invocation-only one.
> 
> Thanks Gary!
> 
> Cheers,
> Miguel