linux-kernel - Re: [PATCH 1/2] maple_tree: fix alloc node fail issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241011010945.usgu7kqjdzimrwo3@master>
Date: Fri, 11 Oct 2024 01:09:45 +0000
From: Wei Yang <richard.weiyang@...il.com>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Jiazi Li <jqqlijiazi@...il.com>, linux-kernel@...r.kernel.org,
	maple-tree@...ts.infradead.org
Subject: Re: [PATCH 1/2] maple_tree: fix alloc node fail issue

On Wed, Jun 26, 2024 at 12:06:30PM -0400, Liam R. Howlett wrote:
>From: Jiazi Li <jqqlijiazi@...il.com>
>
>In the following code, the second call to the mas_node_count will
>return -ENOMEM:
>
>	mas_node_count(mas, MAPLE_ALLOC_SLOTS + 1);
>	mas_node_count(mas, MAPLE_ALLOC_SLOTS * 2 + 2);
>
>This is because there may be some full maple_alloc node in current
>maple state. Use full maple_alloc node will make max_req equal to 0.
>And it leads to mt_alloc_bulk return 0.
>As a result, mas_node_count set mas.node to MA_ERROR(-ENOMEM).
>
>Find a non-full maple_alloc node, and if necessary, use this non-full
>node in the next while loop.
>
>Fixes: 54a611b60590 ("Maple Tree: add new data structure")
>Suggested-by: Liam R. Howlett <Liam.Howlett@...cle.com>
>Signed-off-by: Jiazi Li <jqqlijiazi@...il.com>
>Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>


This looks good to me.

I don't see it is in the master. Not sure this is missed.

-- 
Wei Yang
Help you, Help me