linux-kernel - Re: [PATCH v2] dma-buf: fix S_IRUGO to 0444, block comments, func declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANDhNCpeJFn9NMQYwWT04x=HL2bUi71V6YpQG7Gg5PVVCbRfXw@mail.gmail.com>
Date: Fri, 11 Oct 2024 17:52:56 -0700
From: John Stultz <jstultz@...gle.com>
To: Pintu Kumar <quic_pintu@...cinc.com>
Cc: sumit.semwal@...aro.org, benjamin.gaignard@...labora.com, 
	Brian.Starkey@....com, tjmercier@...gle.com, christian.koenig@....com, 
	linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org, joe@...ches.com, 
	skhan@...uxfoundation.org, pintu.ping@...il.com
Subject: Re: [PATCH v2] dma-buf: fix S_IRUGO to 0444, block comments, func declaration

On Sat, Oct 5, 2024 at 11:10 AM Pintu Kumar <quic_pintu@...cinc.com> wrote:
>
> These warnings/errors are reported by checkpatch.
> Fix them with minor changes to make it clean.
> No other functional changes.
>
> WARNING: Block comments use * on subsequent lines
> +       /* only support discovering the end of the buffer,
> +          but also allow SEEK_SET to maintain the idiomatic
>
> WARNING: Block comments use a trailing */ on a separate line
> +          SEEK_END(0), SEEK_CUR(0) pattern */
>
> WARNING: Block comments use a trailing */ on a separate line
> +        * before passing the sgt back to the exporter. */
>
> ERROR: "foo * bar" should be "foo *bar"
> +static struct sg_table * __map_dma_buf(struct dma_buf_attachment *attach,
>
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +       d = debugfs_create_file("bufinfo", S_IRUGO, dma_buf_debugfs_dir,
>
> total: 1 errors, 4 warnings, 1746 lines checked
>
> Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>

Looks ok to me. Thanks for sending these cleanups!
Acked-by: John Stultz <jstultz@...gle.com>