linux-kernel - Re: [PATCH v3 1/3] mailbox: Introduce support for T-head TH1520 Mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410121547.KF1WUbP1-lkp@intel.com>
Date: Sat, 12 Oct 2024 16:19:41 +0800
From: kernel test robot <lkp@...el.com>
To: Michal Wilczynski <m.wilczynski@...sung.com>, drew@...7.com,
	guoren@...nel.org, wefu@...hat.com, jassisinghbrar@...il.com,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
	m.szyprowski@...sung.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-riscv@...ts.infradead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Michal Wilczynski <m.wilczynski@...sung.com>
Subject: Re: [PATCH v3 1/3] mailbox: Introduce support for T-head TH1520
 Mailbox driver

Hi Michal,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.12-rc2]
[cannot apply to next-20241011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Michal-Wilczynski/mailbox-Introduce-support-for-T-head-TH1520-Mailbox-driver/20241009-015033
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20241008174852.222374-2-m.wilczynski%40samsung.com
patch subject: [PATCH v3 1/3] mailbox: Introduce support for T-head TH1520 Mailbox driver
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20241012/202410121547.KF1WUbP1-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241012/202410121547.KF1WUbP1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410121547.KF1WUbP1-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/mailbox/mailbox-th1520.c: In function 'th1520_mbox_chan_id_to_mapbit':
>> drivers/mailbox/mailbox-th1520.c:196:34: warning: unused variable 'priv' [-Wunused-variable]
     196 |         struct th1520_mbox_priv *priv = to_th1520_mbox_priv(cp->chan->mbox);
         |                                  ^~~~
   drivers/mailbox/mailbox-th1520.c: In function 'th1520_mbox_xlate':
   drivers/mailbox/mailbox-th1520.c:381:34: warning: unused variable 'priv' [-Wunused-variable]
     381 |         struct th1520_mbox_priv *priv = to_th1520_mbox_priv(mbox);
         |                                  ^~~~
   drivers/mailbox/mailbox-th1520.c: In function 'th1520_mbox_probe':
>> drivers/mailbox/mailbox-th1520.c:441:26: warning: unused variable 'res' [-Wunused-variable]
     441 |         struct resource *res;
         |                          ^~~
>> drivers/mailbox/mailbox-th1520.c:439:29: warning: unused variable 'np' [-Wunused-variable]
     439 |         struct device_node *np = dev->of_node;
         |                             ^~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MODVERSIONS
   Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
   Selected by [y]:
   - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=n] || GCC_PLUGINS [=y]) && MODULES [=y]
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [m]:
   - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]


vim +/priv +196 drivers/mailbox/mailbox-th1520.c

   193	
   194	static int th1520_mbox_chan_id_to_mapbit(struct th1520_mbox_con_priv *cp)
   195	{
 > 196		struct th1520_mbox_priv *priv = to_th1520_mbox_priv(cp->chan->mbox);
   197		int mapbit = 0;
   198		int i;
   199	
   200		for (i = 0; i < TH_1520_MBOX_CHANS; i++) {
   201			if (i == cp->idx)
   202				return mapbit;
   203	
   204			if (i != TH_1520_MBOX_ICU_KERNEL_CPU0)
   205				mapbit++;
   206		}
   207	
   208		if (i == TH_1520_MBOX_CHANS)
   209			dev_err(cp->chan->mbox->dev, "convert to mapbit failed\n");
   210	
   211		return 0;
   212	}
   213	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki