linux-kernel - Re: [PATCH 1/7] drm/panic: avoid reimplementing Iterator::find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kG0Ai2DHfERD0aPDVuEpLYrZ_2uYdw17=eeHRp+2Q1Rg@mail.gmail.com>
Date: Sat, 12 Oct 2024 13:04:21 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Thomas Böhler <witcher@...edspace.de>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Jocelyn Falempe <jfalempe@...hat.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] drm/panic: avoid reimplementing Iterator::find

Hi Thomas,

These commit logs are nicely explained -- thanks a lot for taking the
time to write each!

A couple nits below.

On Sat, Oct 12, 2024 at 9:53 AM Thomas Böhler <witcher@...edspace.de> wrote:
>
> implementing the same logic itself.
> Clippy complains about this in the `manual_find` lint:

Typically commit messages use newlines between paragraphs.

> Reported-by: Miguel Ojeda <ojeda@...nel.org>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1123

Since each of these commits fixes part of the issue, I think these are
meant to be `Link:`s instead of `Closes:`s according to the docs:

    https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

In addition, these should probably have a `Fixes:` tag too -- I should
have mentioned that in the issue, sorry.

Finally, as a suggestion for the future: for a series like this, it
may make sense to have a small/quick cover letter saying something as
simple as: "Clippy reports some issues in ... -- this series cleans
them up.". Having a cover letter also allows you to give a title to
the series.

Thanks again!

Cheers,
Miguel