linux-kernel - Commit 610712298b11b2914be00b35abe9326b5dbb62c8 Breaks Bluetooth discovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMb39_=ebMmeCuZQAQS--CnM4PDaBEfJ4pbiG9gtJZkmikohWQ@mail.gmail.com>
Date: Sat, 12 Oct 2024 08:42:21 -0500
From: Walt Holman <waltholman09@...il.com>
To: linux-kernel <linux-kernel@...r.kernel.org>, linux-netdev@...r.kernel.org
Cc: luiz.von.dentz@...el.com
Subject: Commit 610712298b11b2914be00b35abe9326b5dbb62c8 Breaks Bluetooth discovery

Recent 6.12.0-rc kernels include the following commit:

commit 610712298b11b2914be00b35abe9326b5dbb62c8
Author: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>
Date:   Tue Oct 1 11:21:37 2024 -0400

    Bluetooth: btusb: Don't fail external suspend requests

    Commit 4e0a1d8b0675
    ("Bluetooth: btusb: Don't suspend when there are connections")
    introduces a check for connections to prevent auto-suspend but that
    actually ignored the fact the .suspend callback can be called for
    external suspend requests which
    Documentation/driver-api/usb/power-management.rst states the following:

     'External suspend calls should never be allowed to fail in this way,
     only autosuspend calls.  The driver can tell them apart by applying
     the :c:func:`PMSG_IS_AUTO` macro to the message argument to the
     ``suspend`` method; it will return True for internal PM events
     (autosuspend) and False for external PM events.'

    In addition to that align system suspend with USB suspend by using
    hci_suspend_dev since otherwise the stack would be expecting events
    such as advertising reports which may not be delivered while the
    transport is suspended.

    Fixes: 4e0a1d8b0675 ("Bluetooth: btusb: Don't suspend when there
are connections")
    Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>
    Tested-by: Kiran K <kiran.k@...el.com>

This breaks bluetooth on my ASUS ROG GA605WI laptop. I am using a
Qualcomm WCN785x Wi-Fi chip with Quectel Bluetooth. Reverting the
above commit fixes discovery and connection issues with bluetooth on
my laptop.