[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJM55Z_8d10_8g8D_WwYqi_D36JVs+7UdooO9p81Vuwd8odSyw@mail.gmail.com>
Date: Sat, 12 Oct 2024 06:46:02 -0700
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Drew Fustini <dfustini@...storrent.com>, Drew Fustini <drew@...7.com>, Guo Ren <guoren@...nel.org>,
Fu Wei <wefu@...hat.com>, Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Emil Renner Berthing <emil.renner.berthing@...onical.com>,
Thomas Bonnefille <thomas.bonnefille@...tlin.com>
Cc: linux-riscv@...ts.infradead.org, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 6/8] riscv: dts: thead: Add Lichee Pi 4M GPIO line names
Drew Fustini wrote:
> From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
>
> Add names for the GPIO00-GPIO14 lines of the SO-DIMM module.
>
> Tested-by: Thomas Bonnefille <thomas.bonnefille@...tlin.com>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> Signed-off-by: Drew Fustini <dfustini@...storrent.com>
> ---
> .../boot/dts/thead/th1520-lichee-module-4a.dtsi | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
> index bf1c639072b8..ca84bc2039ef 100644
> --- a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
> @@ -29,6 +29,12 @@ &aonsys_clk {
> clock-frequency = <73728000>;
> };
>
> +&aogpio {
> + gpio-line-names = "", "", "",
> + "GPIO00",
> + "GPIO04";
> +};
> +
> &dmac0 {
> status = "okay";
> };
> @@ -48,3 +54,36 @@ &sdio0 {
> max-frequency = <198000000>;
> status = "okay";
> };
> +
> +&gpio0 {
> + gpio-line-names = "", "", "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "", "", "", "",
> + "", "", "", "",
> + "GPIO07",
> + "GPIO08",
> + "",
> + "GPIO01",
> + "GPIO02";
> +};
> +
> +&gpio1 {
> + gpio-line-names = "", "", "",
> + "GPIO11",
> + "GPIO12",
> + "GPIO13",
> + "GPIO14",
> + "", "", "", "", "", "", "", "", "", "",
> + "", "", "", "", "",
> + "GPIO06";
> +};
> +
> +&gpio2 {
> + gpio-line-names = "GPIO03",
> + "GPIO05";
> +};
> +
> +&gpio3 {
> + gpio-line-names = "", "",
> + "GPIO09",
> + "GPIO10";
> +};
Hi Drew,
I just noticed you've moved these entries compared to my original patches, so
they're no longer sorted alphabetically. Why?
Please see https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
under "Order of Nodes".
/Emil
Powered by blists - more mailing lists