linux-kernel - Re: [PATCH v2 1/2] watchdog: apple: Actually flush writes after requesting watchdog restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82433add-b157-4cb8-81f6-0dad6c49dfc7@roeck-us.net>
Date: Sat, 12 Oct 2024 08:51:12 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Nick Chan <towinchenmi@...il.com>, Hector Martin <marcan@...can.st>,
 Sven Peter <sven@...npeter.dev>, Alyssa Rosenzweig <alyssa@...enzweig.io>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-watchdog@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2 1/2] watchdog: apple: Actually flush writes after
 requesting watchdog restart

On 10/1/24 09:59, Nick Chan wrote:
> Although there is an existing code comment about flushing the writes,
> writes were not actually being flushed.
> 
> Actually flush the writes by changing readl_relaxed() to readl().
> 
> Fixes: 4ed224aeaf661 ("watchdog: Add Apple SoC watchdog driver")
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Nick Chan <towinchenmi@...il.com>

Reviewed-by: Guenter Roeck  <linux@...ck-us.net>