[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZwrgdOvfdo8VAR-T@surfacebook.localdomain>
Date: Sat, 12 Oct 2024 23:47:48 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Vasileios Aoiridis <vassilisamir@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, jic23@...nel.org,
lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, anshulusr@...il.com, gustavograzs@...il.com,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 13/13] iio: chemical: bme680: Add support for preheat
current
Fri, Oct 11, 2024 at 09:08:51PM +0200, Vasileios Aoiridis kirjoitti:
> On Fri, Oct 11, 2024 at 01:39:29PM +0300, Andy Shevchenko wrote:
> > On Thu, Oct 10, 2024 at 11:00:30PM +0200, vamoirid wrote:
...
> > > + data->preheat_curr = 0; /* milliamps */
> >
> > Instead of the comment, make it better to any appearance of the variable in the
> > code by adding unit suffix.
> >
> > data->preheat_curr_mA = 0;
> >
> > (yes, capital 'A').
>
> I used the comment here because it is exactly like this above and I
> though it is more consistent if I do the same. But I guess repeating a
> not so good design choice for consistency might not be the best
> decision.
Right. I would rather see an additional patch that adds unit suffixes here
and there...
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists