linux-kernel - Re: [PATCH 1/2] maple_tree: check for MA_STATE_BULK on setting wr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241012033118.33rqa6xlpgxcuidj@master>
Date: Sat, 12 Oct 2024 03:31:18 +0000
From: Wei Yang <richard.weiyang@...il.com>
To: Sidhartha Kumar <sidhartha.kumar@...cle.com>
Cc: linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org,
	linux-mm@...ck.org, akpm@...ux-foundation.org,
	liam.howlett@...cle.com, willy@...radead.org,
	richard.weiyang@...il.com
Subject: Re: [PATCH 1/2] maple_tree: check for MA_STATE_BULK on setting
 wr_rebalance

On Fri, Oct 11, 2024 at 05:44:50PM -0400, Sidhartha Kumar wrote:
>It is possible for a bulk operation (MA_STATE_BULK is set) to enter the
>new_end < mt_min_slots[type] case and set wr_rebalance as a store type.
>This is incorrect as bulk stores do not rebalance per write, but rather
>after the all of the writes are done through the mas_bulk_rebalance()
>path. Therefore, add a check to make sure MA_STATE_BULK is not set
>before we return wr_rebalance as the store type.
>
>Also add a test to make sure wr_rebalance is never the store type when
>doing bulk operations via mas_expected_entries()
>
>Fixes: 5d659bbb52a2 ("maple_tree: introduce mas_wr_store_type()")
>Suggested-by: Liam Howlett <liam.howlett@...cle.com>
>Signed-off-by: Sidhartha <sidhartha.kumar@...cle.com>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>

-- 
Wei Yang
Help you, Help me