linux-kernel - Re: [PATCH next] USB: chaoskey: fix deadlock in release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024101330-atom-womanhood-456a@gregkh>
Date: Sun, 13 Oct 2024 14:03:50 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Oliver Neukum <oneukum@...e.com>, Keith Packard <keithp@...thp.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] USB: chaoskey: fix deadlock in release

On Fri, Oct 11, 2024 at 10:43:50PM +0300, Dan Carpenter wrote:
> This lock should was intended to be an unlock.  It will lead to a hang.
> 
> Fixes: 422dc0a4d12d ("USB: chaoskey: fail open after removal")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> >From static analysis.  Not tested.
> 
>  drivers/usb/misc/chaoskey.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
> index e8b63df5f975..4025f386ba6b 100644
> --- a/drivers/usb/misc/chaoskey.c
> +++ b/drivers/usb/misc/chaoskey.c
> @@ -319,7 +319,7 @@ static int chaoskey_release(struct inode *inode, struct file *file)
>  bail:
>  	mutex_unlock(&dev->lock);
>  destruction:
> -	mutex_lock(&chaoskey_list_lock);
> +	mutex_unlock(&chaoskey_list_lock);
>  	usb_dbg(interface, "release success");
>  	return rv;
>  }
> -- 

The commit at:
	https://lore.kernel.org/r/tencent_84EB865C89862EC22EE94CB3A7C706C59206@qq.com
was tested, so I'll take that one :)

thanks,

greg k-h