[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZwvPMYWYfVFMonDL@gallifrey>
Date: Sun, 13 Oct 2024 13:46:25 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/boot: Remove unused function 'atou'
* linux@...blig.org (linux@...blig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> I can't find any sign of 'atou' having been used.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
Ping
Dave
> ---
> arch/x86/boot/boot.h | 1 -
> arch/x86/boot/string.c | 8 --------
> arch/x86/boot/string.h | 1 -
> 3 files changed, 10 deletions(-)
>
> diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
> index 148ba5c5106e..0f24f7ebec9b 100644
> --- a/arch/x86/boot/boot.h
> +++ b/arch/x86/boot/boot.h
> @@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
> int strcmp(const char *str1, const char *str2);
> int strncmp(const char *cs, const char *ct, size_t count);
> size_t strnlen(const char *s, size_t maxlen);
> -unsigned int atou(const char *s);
> unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
> size_t strlen(const char *s);
> char *strchr(const char *s, int c);
> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
> index c23f3b9c84fe..84f7a883ce1e 100644
> --- a/arch/x86/boot/string.c
> +++ b/arch/x86/boot/string.c
> @@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
> return (es - s);
> }
>
> -unsigned int atou(const char *s)
> -{
> - unsigned int i = 0;
> - while (isdigit(*s))
> - i = i * 10 + (*s++ - '0');
> - return i;
> -}
> -
> /* Works only for digits and letters, but small and fast */
> #define TOLOWER(x) ((x) | 0x20)
>
> diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
> index e5d2c6b8c2f1..a5b05ebc037d 100644
> --- a/arch/x86/boot/string.h
> +++ b/arch/x86/boot/string.h
> @@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
> extern char *strstr(const char *s1, const char *s2);
> extern char *strchr(const char *s, int c);
> extern size_t strnlen(const char *s, size_t maxlen);
> -extern unsigned int atou(const char *s);
> extern unsigned long long simple_strtoull(const char *cp, char **endp,
> unsigned int base);
> long simple_strtol(const char *cp, char **endp, unsigned int base);
> --
> 2.46.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
Powered by blists - more mailing lists