linux-kernel - Re: [PATCH 1/2] arm64: dts: rockchip: Add rk3588-orangepi-5b device tree and refactor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bac3a8702d3e92c401bc4c4d9401258c@manjaro.org>
Date: Sun, 13 Oct 2024 22:55:57 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Cenk Uluisik <cenk.uluisik@...glemail.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Chris
 Morgan <macromorgan@...mail.com>, Jonas Karlman <jonas@...boo.se>, Michael
 Riesch <michael.riesch@...fvision.net>, Andy Yan <andyshrk@....com>, Jimmy
 Hon <honyuenkwun@...il.com>, Jing Luo <jing@...g.rocks>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Add rk3588-orangepi-5b device
 tree and refactor

Hello Cenk,

On 2024-10-13 22:44, Cenk Uluisik wrote:
> Implements a slightly modified rk3588s-orangepi-5b.dts from the vendor.
> Unfortunately the &wireless_bluetooth and &wireless_wlan overlays don't 
> seem
> to compile, so I removed them for now:
> 
> Error: arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts:20.1-20
> Label or path wireless_bluetooth not found
> Error: arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts:24.1-15
> Label or path wireless_wlan not found
> 
> Bigger parts of the rk3588s-orangepi-5.dts file were moved into a new
> rk3588s-orangepi-5.dtsi file, so that both device trees from the
> orangepi-5 and 5b include from it and avoid including from the .dts.
> 
> How does this board differ from the original Orange Pi 5?
>   - builtin eMMC storage
>   - no SPI NOR flash (u-boot, preboot etc. initiates from within the 
> eMMC
>     storage)
>   - ap6275p Wifi module (like the Orange Pi 5 Plus)
>   - builtin BlueTooth module
> 
> Beside that everything is exactly the same as far as I know.
> 
> Signed-off-by: Cenk Uluisik <cenk.uluisik@...glemail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588s-orangepi-5.dts  | 760 +----------------
>  .../boot/dts/rockchip/rk3588s-orangepi-5.dtsi | 763 ++++++++++++++++++
>  .../boot/dts/rockchip/rk3588s-orangepi-5b.dts |  18 +
>  4 files changed, 784 insertions(+), 758 deletions(-)
>  create mode 100644 
> arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi
>  create mode 100644 
> arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts

Please try using the --break-rewrites [*] to generate the patches,
which should produce much shorter diffs, easier to review.

Also, please enumerate the patch versions.  E.g., this should be v2,
and I'm not sure what happened with the multiple v1s you sent earlier.

[*] 
https://git-scm.com/docs/diff-options#Documentation/diff-options.txt---break-rewritesltngtltmgt