linux-kernel - Re: [PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc3ddbdd-fc69-4858-801d-561d03ce388c@quicinc.com>
Date: Sun, 13 Oct 2024 20:20:29 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Lucas De Marchi
	<lucas.demarchi@...el.com>,
        Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        Jessica Zhang <quic_jesszhan@...cinc.com>,
        Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>
CC: <intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <freedreno@...ts.freedesktop.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC_HELPER selection



On 10/13/2024 8:11 PM, Abhinav Kumar wrote:
> 
> 
> On 9/4/2024 8:08 PM, Dmitry Baryshkov wrote:
>> In the drm/msm driver both DSI and DPU subdrivers use drm_dsc_*
>> functions, but only DSI selects DRM_DISPLAY_DSC_HELPER symbol. Add
>> missing select to the DPU subdriver too.
>>
>> Fixes: ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: 
>> https://lore.kernel.org/oe-kbuild-all/202409040129.rqhtRTeC-lkp@intel.com/
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> ---
>>   drivers/gpu/drm/msm/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
> 
> Change LGTM, hence
> 
> Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> 
> But, ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers") is 
> not yet merged, so I will not be able to pick this up for this cycle?
>

Please ignore, I just noticed this series was applied through drm-misc.

>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>> index 94d3ed4f7761..c8dda0ebd043 100644
>> --- a/drivers/gpu/drm/msm/Kconfig
>> +++ b/drivers/gpu/drm/msm/Kconfig
>> @@ -92,6 +92,7 @@ config DRM_MSM_DPU
>>       bool "Enable DPU support in MSM DRM driver"
>>       depends on DRM_MSM
>>       select DRM_MSM_MDSS
>> +    select DRM_DISPLAY_DSC_HELPER
>>       default y
>>       help
>>         Compile in support for the Display Processing Unit in
>>