linux-kernel - Re: [RFC PATCH net-next 1/1] net: phy: Add capability to enable/disable 2.5G/5G/10G AN in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c55b353-ddaf-48f2-985c-5cb67bd5cb0c@lunn.ch>
Date: Mon, 14 Oct 2024 15:36:55 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sky Huang <SkyLake.Huang@...iatek.com>,
	Gerhard Engleder <gerhard@...leder-embedded.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Steven Liu <Steven.Liu@...iatek.com>
Subject: Re: [RFC PATCH net-next 1/1] net: phy: Add capability to
 enable/disable 2.5G/5G/10G AN in ethtool

On Mon, Oct 14, 2024 at 02:06:03PM +0800, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@...iatek.com>
> 
> For phy loopback test, we need to disable AN. In this way,
> users can disable/enable phy AN more conveniently.

Please take a look at:

https://lore.kernel.org/netdev/20241013202430.93851-1-gerhard@engleder-embedded.com/T/

We need a good understanding of how 802.3 expects loopback to be used,
and a commit message based on what 802.3 says. Our current
understanding is that 1G and above requires auto-neg for correct
operation, so we don't want to allow autoneg to be disabled in normal
operation. It could be we need to special case loopback somehow.

	Andrew