linux-kernel - Re: [PATCH] watchdog: Add HAS_IOPORT dependency for SBC8360 and SBC7240

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34c582cd-8321-4ee6-bab5-a285f332e103@roeck-us.net>
Date: Mon, 14 Oct 2024 06:46:54 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Niklas Schnelle <schnelle@...ux.ibm.com>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Arnd Bergmann <arnd@...nel.org>
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: Add HAS_IOPORT dependency for SBC8360 and
 SBC7240

On 10/14/24 04:25, Niklas Schnelle wrote:
> Both drivers use I/O port accesses without declaring a dependency on
> CONFIG_HAS_IOPORT. For sbc8360_wdt this causes a compile error on UML
> once inb()/outb() helpers become conditional.
> 
> For sbc7240_wdt this causes no such errors with UML because this driver
> depends on both x86_32 and !UML. Nevertheless add HAS_IOPORT as
> a dependency for both drivers to be explicit and drop the !UML
> dependency for sbc7240_wdt as it is now redundant since UML implies no
> HAS_IOPORT.
> 
> Fixes: 52df67b6b313 ("watchdog: add HAS_IOPORT dependencies")
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>