linux-kernel - Re: [PATCH v4 27/28] media: iris: enable video driver probe of SM8250 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zw0j9UeJmC1MZ3Xt@localhost.localdomain>
Date: Mon, 14 Oct 2024 22:00:21 +0800
From: Jianhua Lu <lujianhua000@...il.com>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>
Cc: Vikash Garodia <quic_vgarodia@...cinc.com>,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Hans Verkuil <hverkuil@...all.nl>,
	Sebastian Fricke <sebastian.fricke@...labora.com>,
	linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 27/28] media: iris: enable video driver probe of
 SM8250 SoC

On Mon, Oct 14, 2024 at 02:37:48PM +0530, Dikshita Agarwal wrote:
> Initialize the platform data and enable video driver
> probe of SM8250 SoC.
> 
> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
> ---
[..] 
> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index 86ef2e5c488e..a2aadd48926f 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
> @@ -325,6 +325,10 @@ static const struct of_device_id iris_dt_match[] = {
>  		.compatible = "qcom,sm8550-iris",
>  		.data = &sm8550_data,
>  	},
> +	{
> +		.compatible = "qcom,sm8250-venus",
> +		.data = &sm8250_data,
> +	},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, iris_dt_match);

qcom-venus driver has already supported sm8250 soc, I think you should add
an extra patch to drop sm8250 releated code from qcom-venus driver if you
tend to add support for sm8250 in qcom-iris driver.