linux-kernel - Re: [PATCH] perf: arm-cmn: remove unused macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce396f01-e10c-41ce-b3d8-19c626d68241@arm.com>
Date: Mon, 14 Oct 2024 15:12:14 +0100
From: Robin Murphy <robin.murphy@....com>
To: Ba Jing <bajing@...s.chinamobile.com>
Cc: will@...nel.org, mark.rutland@....com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: arm-cmn: remove unused macro

On 12/10/2024 10:24 am, Ba Jing wrote:
> By reading the code, I found the marco CMN_HNP_PMU_EVENT_SEL
> is never referenced in the code. Just remove it.

Hmm, perhaps I got a little carried away implementing Mark's 
recommendation in 88b63a82c84e ("perf/arm-cmn: Fix CCLA register 
offset"), and the HN-P/CCLA_RNI case could have been left as it was 
using CMN_HNP_PMU_EVENT_SEL. Either way, I think it's beneficial to keep 
both definitions next to each other, so that it's at least visible from 
the code alone (without having to resort to the CMN documentation) that 
the two node types do have equivalent offsets and that combined case is 
still not a bug.

Thanks,
Robin.

> Signed-off-by: Ba Jing <bajing@...s.chinamobile.com>
> ---
>   drivers/perf/arm-cmn.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 397a46410f7c..37b62d0dcc06 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -79,7 +79,6 @@
>   
>   /* Some types are designed to coexist with another device in the same node */
>   #define CMN_CCLA_PMU_EVENT_SEL		0x008
> -#define CMN_HNP_PMU_EVENT_SEL		0x008
>   
>   /* DTMs live in the PMU space of XP registers */
>   #define CMN_DTM_WPn(n)			(0x1A0 + (n) * 0x18)